OpenSearchISMPolicy - shrink action has a maxShardSize required property which is invalid #750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the following
OpenSearchISMPolicy
And I am receving the following error when validating the schema:
The error is saying that the
maxShardSize
property is required, but themaxShardSize
property is not required in theshrink
action for all permutations of how it can be used.See the official documentation:
https://opensearch.org/docs/latest/im-plugin/ism/policies/#shrink
![image](https://private-user-images.githubusercontent.com/73483987/310545728-bcddf575-9192-4bdd-9bbe-0f2a8d9f0c0d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjA4MTEsIm5iZiI6MTczOTMyMDUxMSwicGF0aCI6Ii83MzQ4Mzk4Ny8zMTA1NDU3MjgtYmNkZGY1NzUtOTE5Mi00YmRkLTliYmUtMGYyYThkOWYwYzBkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAwMzUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk5MWMxNTg3YzY1MjkwMTAxMjhhMzMxOWQ1NTE3MTJmYmRmMmQ5ZmYwM2E0MDIzYjIyMjA3ZGI5YTJlZWM0NDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lnhkfvfIg-8HRh2xy7FCockrtJAtLC_iXBUUi1bSUhk)
You are already handling the properties here:
opensearch-operator/pkg/reconcilers/ismpolicy.go
But we need to update the schema.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.