Make the BMC MAC address field required

openshift-assisted · Jan 3, 2024 · 342be7c · 342be7c
1 parent 60013a3
commit 342be7c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/libs/locales/lib/en/translation.json b/libs/locales/lib/en/translation.json
@@ -706,7 +706,7 @@
   "ai:The hosts you selected are using different proxy settings. Configure a proxy that will be applied for these hosts. <bold>Configure at least one of the proxy settings below.</bold>": "The hosts you selected are using different proxy settings. Configure a proxy that will be applied for these hosts. <bold>Configure at least one of the following proxy settings.</bold>",
   "ai:The HTTP proxy URL that agents should use to access the discovery service.": "The HTTP proxy URL that agents should use to access the discovery service.",
   "ai:The IP address pool to use for service IP addresses. You can enter only one IP address pool. If you need to access the services from an external network, configure load balancers and routers to manage the traffic.": "The IP address pool to use for service IP addresses. You can enter only one IP address pool. If you need to access the services from an external network, configure load balancers and routers to manage the traffic.",
-  "ai:The MAC address of the host's network connected NIC that will be used to provision the host. Required for libvirt VMs driven by vbmc.": "The MAC address of the host's network connected NIC that will be used to provision the host. Required for libvirt VMs driven by vbmc.",
+  "ai:The MAC address of the host's network connected NIC that will be used to provision the host.": "The MAC address of the host's network connected NIC that will be used to provision the host.",
   "ai:The output displays the following:": "The output displays the following:",
   "ai:The resource has been saved and the YAML is now read only.": "The resource has been saved and the YAML is now read only.",
   "ai:The resource you are changing is already in use by hosts in the infrastructure environment. A change will require booting the hosts with a new discovery ISO file.": "The resource you are changing is already in use by hosts in the infrastructure environment. A change will require booting the hosts with a new discovery ISO file.",

diff --git a/libs/ui-lib/lib/cim/components/Agent/BMCForm.tsx b/libs/ui-lib/lib/cim/components/Agent/BMCForm.tsx
@@ -279,8 +279,9 @@ const BMCForm: React.FC<BMCFormProps> = ({
                 name="bootMACAddress"
                 placeholder={t('ai:Enter an address')}
                 description={t(
-                  "ai:The MAC address of the host's network connected NIC that will be used to provision the host. Required for libvirt VMs driven by vbmc.",
+                  "ai:The MAC address of the host's network connected NIC that will be used to provision the host.",
                 )}
+                isRequired
               />
               <InputField
                 label={t('ai:Username')}

diff --git a/libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts b/libs/ui-lib/lib/common/components/ui/formik/validationSchemas.ts
@@ -642,7 +642,7 @@ export const day2ApiVipValidationSchema = Yup.string().test(
 export const bmcAddressValidationSchema = (t: TFunction) => {
   const bmcAddressValidationMessagesList = bmcAddressValidationMessages(t);
 
-  return Yup.string().matches(BMC_REGEX, {
+  return Yup.string().required().matches(BMC_REGEX, {
     message: bmcAddressValidationMessagesList.INVALID_VALUE,
     excludeEmptyString: true,
   });