Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15791: Its not clear when is the boot mac address required #2430

Merged
merged 1 commit into from
Jan 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/locales/lib/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@
"ai:The hosts you selected are using different proxy settings. Configure a proxy that will be applied for these hosts. <bold>Configure at least one of the proxy settings below.</bold>": "The hosts you selected are using different proxy settings. Configure a proxy that will be applied for these hosts. <bold>Configure at least one of the following proxy settings.</bold>",
"ai:The HTTP proxy URL that agents should use to access the discovery service.": "The HTTP proxy URL that agents should use to access the discovery service.",
"ai:The IP address pool to use for service IP addresses. You can enter only one IP address pool. If you need to access the services from an external network, configure load balancers and routers to manage the traffic.": "The IP address pool to use for service IP addresses. You can enter only one IP address pool. If you need to access the services from an external network, configure load balancers and routers to manage the traffic.",
"ai:The MAC address of the host's network connected NIC that will be used to provision the host. Required for libvirt VMs driven by vbmc.": "The MAC address of the host's network connected NIC that will be used to provision the host. Required for libvirt VMs driven by vbmc.",
"ai:The MAC address of the host's network connected NIC that will be used to provision the host.": "The MAC address of the host's network connected NIC that will be used to provision the host.",
"ai:The output displays the following:": "The output displays the following:",
"ai:The resource has been saved and the YAML is now read only.": "The resource has been saved and the YAML is now read only.",
"ai:The resource you are changing is already in use by hosts in the infrastructure environment. A change will require booting the hosts with a new discovery ISO file.": "The resource you are changing is already in use by hosts in the infrastructure environment. A change will require booting the hosts with a new discovery ISO file.",
Expand Down
3 changes: 2 additions & 1 deletion libs/ui-lib/lib/cim/components/Agent/BMCForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,9 @@ const BMCForm: React.FC<BMCFormProps> = ({
name="bootMACAddress"
placeholder={t('ai:Enter an address')}
description={t(
"ai:The MAC address of the host's network connected NIC that will be used to provision the host. Required for libvirt VMs driven by vbmc.",
"ai:The MAC address of the host's network connected NIC that will be used to provision the host.",
)}
isRequired
/>
<InputField
label={t('ai:Username')}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ export const day2ApiVipValidationSchema = Yup.string().test(
export const bmcAddressValidationSchema = (t: TFunction) => {
const bmcAddressValidationMessagesList = bmcAddressValidationMessages(t);

return Yup.string().matches(BMC_REGEX, {
return Yup.string().required().matches(BMC_REGEX, {
message: bmcAddressValidationMessagesList.INVALID_VALUE,
excludeEmptyString: true,
});
Expand Down
Loading