Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACM-17263: Add a host using BMC form should have a validation for BMC address #2776

Merged
merged 2 commits into from
Feb 25, 2025
Merged

ACM-17263: Add a host using BMC form should have a validation for BMC address #2776

merged 2 commits into from
Feb 25, 2025

Conversation

jgyselov
Copy link
Collaborator

@jgyselov jgyselov requested a review from a team as a code owner January 31, 2025 12:35
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2025 •
edited by openshift-ci bot
Loading

@jgyselov: This pull request references ACM-17263 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/ACM-17263

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2025
@jgyselov jgyselov added this to the v2.14-cim milestone Feb 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov mentioned this pull request Feb 25, 2025
Merged
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 25, 2025

New changes are detected. LGTM label has been removed.

@jgyselov jgyselov merged commit 783c45a into openshift-assisted:master Feb 25, 2025
7 checks passed
@jgyselov jgyselov deleted the bmc_address_regex branch February 25, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner approved these changes

@ammont82 ammont82 ammont82 approved these changes

Assignees

@rawagner rawagner

@ammont82 ammont82

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v2.14-cim
Development

Successfully merging this pull request may close these issues.
4 participants
@jgyselov @openshift-ci-robot @rawagner @ammont82