Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: Show GPUs #2779

Merged
merged 1 commit into from
Feb 12, 2025
Merged

NO-ISSUE: Show GPUs #2779

merged 1 commit into from
Feb 12, 2025

Conversation

jhernand
Copy link
Contributor

This patch adds a GPUs section to the host inventory that shows the list of GPUs detected. For example, in a virtual machine with an AMD GPU and a VirtIO GPU:

gpus

@jhernand
NO-ISSUE: Show GPUs
c4e300d 
This patch adds a _GPUs_ section to the host inventory that shows the
list of GPUs detected.

Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
@jhernand jhernand requested a review from a team as a code owner February 12, 2025 11:20
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 12, 2025
@openshift-ci-robot
Copy link

@jhernand: This pull request explicitly references no jira issue.

In response to this:

This patch adds a GPUs section to the host inventory that shows the list of GPUs detected. For example, in a virtual machine with an AMD GPU and a VirtIO GPU:

gpus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2025
@nirfarkas
Copy link
Contributor

Super nice!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jhernand

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 79c1c35 into openshift-assisted:master Feb 12, 2025
7 checks passed
@ammont82 ammont82 added this to the v2.38 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammont82 ammont82 ammont82 approved these changes

Assignees

@ammont82 ammont82

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v2.38
Development

Successfully merging this pull request may close these issues.
4 participants
@jhernand @openshift-ci-robot @nirfarkas @ammont82