Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19778: Steps of configuring of Standalone cluster are not progressing #2787

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

jgyselov
Copy link
Collaborator

@jgyselov jgyselov commented Feb 19, 2025

https://issues.redhat.com/browse/MGMT-19778

Changes made:

After initially creating the cluster, you continue with the host selection/discovery step due to the initialStep url parameter.

Screenshot from 2025-02-24 12-04-03

The "status text" replaces the Next button text instead of being next to it.

Screenshot from 2025-02-24 12-04-08
Screenshot from 2025-02-24 12-04-18

In case of "Spec Sync error" you are allowed to move around the wizard but not allowed to proceed with installation. Previously, this error blocked users from doing anything.

Screenshot from 2025-02-24 12-07-26
Screenshot from 2025-02-24 12-07-18

@jgyselov jgyselov requested a review from a team as a code owner February 19, 2025 15:38
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2025

@jgyselov: This pull request references MGMT-19778 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-19778

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 19, 2025
@jgyselov jgyselov force-pushed the cim_wizard_rework branch 4 times, most recently from e8eb06e to 0bddb4a Compare February 20, 2025 07:48
@jgyselov jgyselov added this to the v2.14-cim milestone Feb 24, 2025
Copy link
Contributor

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cherry-picked #2773 on top of this branch to test out the creation flow, but I am stuck on Networking page. After filling in the VIPs, they never get into AgentClusterInstall. When I click Next, the button gets stuck on Validating..

@ammont82
Copy link
Contributor

@jgyselov can you attach some video or some screenshots with the new changes? Thanks

ammont82
ammont82 previously approved these changes Feb 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@jgyselov
Copy link
Collaborator Author

I cherry-picked #2773 on top of this branch to test out the creation flow, but I am stuck on Networking page. After filling in the VIPs, they never get into AgentClusterInstall. When I click Next, the button gets stuck on Validating..

Did you include the console part as well? Submitting the IPs will not work without it and the cluster will never be allowed to continue from Networking. @rawagner

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2025

@jgyselov: This pull request references MGMT-19778 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-19778

Changes made:

After initially creating the cluster, you continue with the host selection/discovery step due to the initialStep url parameter.

Screenshot from 2025-02-24 12-04-03

The "status text" replaces the Next button text instead of being next to it.

Screenshot from 2025-02-24 12-04-08
Screenshot from 2025-02-24 12-04-18

In case of "Spec Sync error" you are allowed to move around the wizard but not allowed to proceed with installation. Previously, this error blocked users from doing anything.

Screenshot from 2025-02-24 12-07-26
Screenshot from 2025-02-24 12-07-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rawagner
Copy link
Contributor

I cherry-picked #2773 on top of this branch to test out the creation flow, but I am stuck on Networking page. After filling in the VIPs, they never get into AgentClusterInstall. When I click Next, the button gets stuck on Validating..

Did you include the console part as well? Submitting the IPs will not work without it and the cluster will never be allowed to continue from Networking. @rawagner

I did not! Thanks!

rawagner
rawagner previously approved these changes Feb 24, 2025
@jgyselov jgyselov dismissed stale reviews from rawagner and ammont82 via 96d2786 February 25, 2025 11:50
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
Copy link

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov merged commit 2d74757 into openshift-assisted:master Feb 25, 2025
7 checks passed
@jgyselov jgyselov deleted the cim_wizard_rework branch February 25, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants