Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-1120: Initial Assisted disconnected UI #2789

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Feb 20, 2025

Note that the purpose of this PR is not to setup a fully-functional UI, but to setup an infrastructure to be able to build & publish the new app

@rawagner rawagner requested a review from a team as a code owner February 20, 2025 16:11
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2025

@rawagner: This pull request references AGENT-1120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2025
@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 20, 2025
@rawagner rawagner force-pushed the ove branch 7 times, most recently from e33fcde to 1225091 Compare February 21, 2025 10:24
@rawagner rawagner changed the title AGENT-1120: Initial Assisted Virt UI AGENT-1120: Initial Assisted disconnected UI Feb 21, 2025
@rawagner rawagner force-pushed the ove branch 2 times, most recently from cbbb796 to 50c93f0 Compare February 24, 2025 10:20
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2025

@rawagner: This pull request references AGENT-1120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Note that the purpose of this PR is not to setup a fully-functional UI, but to setup an infrastructure to be able to build & publish the new app

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
Copy link

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
Copy link

openshift-ci bot commented Feb 25, 2025

New changes are detected. LGTM label has been removed.

@rawagner rawagner merged commit e5545be into openshift-assisted:master Feb 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants