Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable all integration testing on grpc broker. #242

Merged

Conversation

morvencao
Copy link
Contributor

@morvencao morvencao commented Jan 9, 2025

ref: https://issues.redhat.com/browse/ACM-16832
ensure all integration test cases can be run against both MQTT and gRPC broker.

Signed-off-by: morvencao <lcao@redhat.com>
@clyang82
Copy link
Contributor

clyang82 commented Jan 9, 2025

/ok-to-test

Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we may consider to add some metrics for grpc broker in the future

@clyang82 clyang82 merged commit 3ddc36c into openshift-online:main Jan 13, 2025
7 checks passed
@morvencao morvencao deleted the br_integration_test_on_grpc_broker branch January 13, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants