Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang to 1.23.4 #263

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Upgrade golang to 1.23.4 #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
941b11a
Upgrade golang to 1.23.6
clyang82 Feb 18, 2025
6f3948e
use 1.23.4
clyang82 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
- main

env:
GO_VERSION: '1.21'
GO_VERSION: '1.23'
GO_REQUIRED_MIN_VERSION: ''

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .tekton/integration-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ spec:
dnf -y install jq git make

# Install golang with a given version
export GOVERSION=1.22.5
export GOVERSION=1.23.4
curl -O -J https://dl.google.com/go/go$GOVERSION.linux-amd64.tar.gz
rm -rf /usr/local/go && tar -C /usr/local -xzf go$GOVERSION.linux-amd64.tar.gz

Expand Down
2 changes: 1 addition & 1 deletion .tekton/unit-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ spec:
dnf -y install jq git make

# Install golang with a given version
export GOVERSION=1.22.5
export GOVERSION=1.23.4
curl -O -J https://dl.google.com/go/go$GOVERSION.linux-amd64.tar.gz
rm -rf /usr/local/go && tar -C /usr/local -xzf go$GOVERSION.linux-amd64.tar.gz

Expand Down
2 changes: 1 addition & 1 deletion Containerfile.rhtap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_1.22 AS builder
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_1.23 AS builder

ENV SOURCE_DIR=/maestro
WORKDIR $SOURCE_DIR
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22 AS builder
FROM golang:1.23 AS builder

ENV SOURCE_DIR=/maestro
WORKDIR $SOURCE_DIR
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ help:

# Encourage consistent tool versions
OPENAPI_GENERATOR_VERSION:=5.4.0
GO_VERSION:=go1.22.
GO_VERSION:=go1.23.

### Constants:
version:=$(shell date +%s)
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/openshift-online/maestro

go 1.22.5
go 1.23.4

require (
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.12.0
Expand Down
2 changes: 1 addition & 1 deletion pr_check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function cleanUp {
}
trap cleanUp EXIT

test -f go1.22.5.linux-amd64.tar.gz || curl -O -J https://dl.google.com/go/go1.22.5.linux-amd64.tar.gz
test -f go1.23.4.linux-amd64.tar.gz || curl -O -J https://dl.google.com/go/go1.23.4.linux-amd64.tar.gz

podman build -t "$IMAGE_NAME" -f Dockerfile.test .

Expand Down
Loading