Skip to content

Commit

Permalink
Changed the default value for OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY to true
Browse files Browse the repository at this point in the history
  • Loading branch information
Hector Vido committed Feb 28, 2025
1 parent 3c2d3f2 commit b004b8a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ set -o nounset
set -o errexit
set -o pipefail

if [[ "${OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY}" != "true" ]]
then
return
fi

export AWS_SHARED_CREDENTIALS_FILE="${CLUSTER_PROFILE_DIR}/.awscred"

function join_by { local IFS="$1"; shift; echo "$*"; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ref:
- name: EDGE_NODE_WORKER_ASSIGN_PUBLIC_IP
default: "no"
- name: OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY
default: ""
default: "true"
documentation: "Whether to use public only subnets. Implies no NAT gateways. Requires a VPC to be configured prior to install"
- name: TF_LOG
default: "INFO"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ ref:
default: "false"
documentation: "Use AWS Spot Instances for *master* nodes. Set to 'true' to opt into spot instances. Explicitly set to 'false' to opt out. Leave unset for the default, which may change. Note that spot masters are only supported when installing with a) CAPI; or b) newer installer versions (see https://github.com/openshift/installer/pull/8349). A preflight check will fail if this variable is set to 'true' for an unsupported configuration."
- name: OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY
default: ""
default: "true"
documentation: "Whether to use only public subnets for AWS. Implies no NAT Gateways. Requires a VPC to be configured prior to install."
dependencies:
- name: "release:latest"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ chain:
- ref: ipi-install-rbac
- ref: openshift-cluster-bot-rbac
- ref: ipi-install-hosted-loki
- ref: ipi-conf-aws-publicsubnets
- ref: ipi-install-install
- ref: ipi-install-times-collection
- ref: nodes-readiness
Expand Down

0 comments on commit b004b8a

Please sign in to comment.