Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCKER] fix controller port #1859

Merged
merged 3 commits into from
Feb 5, 2025
Merged

[DOCKER] fix controller port #1859

merged 3 commits into from
Feb 5, 2025

Conversation

TaiJuWu
Copy link
Contributor

@TaiJuWu TaiJuWu commented Feb 5, 2025

This PR do follow:

  • cherry pick cbc08ca
  • restore generateControllerPort
  • check docker start up successfully.

@TaiJuWu TaiJuWu changed the title fix controller port [DOCKER] fix controller port Feb 5, 2025
@TaiJuWu TaiJuWu marked this pull request as draft February 5, 2025 12:18
echo "================================================="
echo "run CLUSTER_ID=$CLUSTER_ID $DOCKER_FOLDER/start_broker.sh controller.quorum.bootstrap.servers=${ADDRESS}:$CONTROLLER_PORT to join broker"
echo "================================================="
if [ "$(echo $?)" -eq 0 ]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add error check.

@@ -25,6 +25,24 @@ function getRandomPort() {
echo $(($(($RANDOM%10000))+10000))
}


# we need to parse the controller port from pre-defined `VOTERS`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is removed within in 9fab2a0.

@TaiJuWu TaiJuWu marked this pull request as ready for review February 5, 2025 13:24
@chia7712 chia7712 merged commit 3dbac43 into opensource4you:main Feb 5, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants