Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/zy/cla check #5

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Feature/zy/cla check #5

merged 2 commits into from
Dec 9, 2024

Conversation

ssignik
Copy link
Collaborator

@ssignik ssignik commented Dec 9, 2024

1.validate input parameter in review certificate
2.cla check

@ssignik ssignik requested a review from LiYanghang00 December 9, 2024 08:42
@shishupei
Copy link

开始门禁检查,等门禁检查通过后可以合入

import org.springframework.web.client.RestTemplate;

@Data
@Slf4j
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个逐渐是否可以去掉

* cla签署校验
*
* @param request request
* @return JsonResponse
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改成 是否签署cla

public boolean check(String email) {
String queryUrl = checkUrl + "?email=" + email;
HttpEntity<String> entity = new HttpEntity<>(null, null);
ResponseEntity<String> responseEntity = restTemplate.exchange(queryUrl, HttpMethod.GET, entity, String.class);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果失败是否需要加上重试

@shishupei
Copy link

检查项 状态 日志
Check代码检查 查看日志
DT覆盖率 7.31603% 查看日志
敏感信息扫描 查看日志
漏洞扫描 查看日志
安全编码扫描 查看日志
TestPlan接口测试
流水线链接 点击跳转

@ssignik ssignik merged commit 667e11b into main Dec 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants