Upgrade sdk libraries to latest versions #2825

ellykits · 2023-10-18T10:16:44Z

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2816

Engineer Checklist

I have written Unit tests for any new feature(s) and edge cases for bug fixes
I have added any strings visible on UI components to the strings.xml file
I have updated the CHANGELOG.md file for any notable changes to the codebase
I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

I have verified Unit tests have been written for any new feature(s) and edge cases
I have verified any strings visible on UI components are in the strings.xml file
I have verifed the CHANGELOG.md file has any notable changes to the codebase
I have verified the solution has been implemented in a configurable and generic way for reuseable components
I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

android/gradle/libs.versions.toml

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Remove extra libraries | upgrade sdk workflow libs * Update Kotlin version to 1.8.20 Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> --------- Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>

…nto upgrade-sdk-libraries Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

…nto upgrade-sdk-libraries

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Issue resolved by using this property on the debug build variant "enableUnitTestCoverage" instead of "isTestCoverageEnabled". "isTestCoverageEnabled" is deprecated and uses jacoco under the hood. Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

ellykits · 2023-11-01T13:35:50Z

The blocker has been resolved.

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

ndegwamartin · 2024-02-06T17:36:22Z

@vitorpamplona I've reverted the dependencies workaround on a separate branch here : https://github.com/opensrp/fhircore/tree/no-dep-workaround

vitorpamplona · 2024-02-06T18:36:39Z

Nice, are you getting the right versions on the HAPI Fhir now?

android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirCarePlanGenerator.kt

ndegwamartin · 2024-02-06T19:09:33Z

Nice, are you getting the right versions on the HAPI Fhir now?

Not yet, with this state it doesn't even compile. Created the branch so that it is easy for you to replicate the issue by just trying to build.

ndegwamartin · 2024-02-07T12:55:24Z

Nice, are you getting the right versions on the HAPI Fhir now?

Not yet, with this state it doesn't even compile. Created the branch so that it is easy for you to replicate the issue by just trying to build.

@vitorpamplona were you able to replicate?

* main: Add icons to be displayed on eusm service point register. (#3047) Upgrade sdk libraries to latest versions (#2825) Make Login Screen Logo Size Configurable (#3045) # Conflicts: # android/gradle/libs.versions.toml # android/quest/src/main/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireActivity.kt

Migrate to latest FHIR SDK Artifacts 💚 * Uprade Gradle dependencies * Upgrade Kotlin version * Clean up unused dependencies * Change CI JDK version to 17 * Refactor tests in quest module * Disable integration tests * Implement support Careplan generation using fhirOperator library | $Apply * Move Configs to Constants object - update documentation * Remove Guava cache config from build: Enforced by SDK * Update CHANGELOG.md * Refactor Dollar Lite to function --------- Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> Co-authored-by: owais-vd <owais.ali@venturedive.com> Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com> Co-authored-by: Rkareko <rkareko@ona.io> Co-authored-by: Debbie Mong'are <debbiearita96@gmail.com> Co-authored-by: Simon Njoroge <snjoroge@ona.io> Co-authored-by: Peter Lubell-Doughtie <peter@ona.io> Co-authored-by: Vitor Pamplona <vitor@vitorpamplona.com> Co-authored-by: Martin Ndegwa <mndegwa@ona.io> Co-authored-by: maimoonak <maimoona.kausar@venturedive.com>

* main: Add icons to be displayed on eusm service point register. (#3047) Upgrade sdk libraries to latest versions (#2825) Make Login Screen Logo Size Configurable (#3045) # Conflicts: # android/gradle/libs.versions.toml # android/quest/src/main/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireActivity.kt

ellykits and others added 5 commits October 16, 2023 18:18

Uprade gradle dependencies

cf94e7f

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

WIP

83a5f79

Refactor failing tests

a004aed

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Merge branch 'main' into upgrade-sdk-libraries

f1232a1

Merge branch 'apply-testing' into upgrade-sdk-libraries

ee98977

ellykits added Blocked Item is blocked by another prerequisite DNM DO NOT MERGE Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions labels Oct 18, 2023

ellykits self-assigned this Oct 18, 2023

Refactor failing tests quest module

a517d48

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

ndegwamartin reviewed Oct 23, 2023

View reviewed changes

android/gradle/libs.versions.toml Outdated Show resolved Hide resolved

ellykits and others added 13 commits October 24, 2023 11:51

Merge branch 'main' into upgrade-sdk-libraries

566dd1c

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Merge branch 'main' into upgrade-sdk-libraries

d822140

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Fix failing build

757ef9b

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Update Kotlin version to 1.8.20

3a0640a

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Merge branch 'upgrade-sdk-libraries' of github.com:opensrp/fhircore i…

316d851

…nto upgrade-sdk-libraries Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Merge branch 'main' into upgrade-sdk-libraries

69bf5a6

Merge branch 'upgrade-sdk-libraries' of github.com:opensrp/fhircore i…

7ec1fc6

…nto upgrade-sdk-libraries

Delete unused dependencies

f374de4

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Update sdk library versions

1935bc6

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Disable code coverage

ebbcca7

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Merge branch 'main' into upgrade-sdk-libraries

0f6e4f2

ellykits removed Blocked Item is blocked by another prerequisite DNM DO NOT MERGE labels Nov 1, 2023

ellykits marked this pull request as ready for review November 1, 2023 13:35

ellykits added 2 commits November 1, 2023 16:43

Change CI JDK version to 17

e122456

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

Refactor tests in quest module

6b22858

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

pld enabled auto-merge (squash) February 6, 2024 18:44

Update CHANGELOG.md

676c881

pld previously approved these changes Feb 6, 2024

View reviewed changes

android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirCarePlanGenerator.kt Outdated Show resolved Hide resolved

pld dismissed their stale review via 85cd72c February 6, 2024 19:16

remove comments

85cd72c

pld previously approved these changes Feb 6, 2024

View reviewed changes

ndegwamartin added 2 commits February 7, 2024 14:04

Refactor Dollar Lite to function

1417f48

Upgrade Engine and SDC artifacts

26c551b

ndegwamartin dismissed pld’s stale review via 26c551b February 7, 2024 11:05

ndegwamartin added 2 commits February 7, 2024 16:13

Fix Build ✅

ff6f2dd

Upgrade Engine + SDC artifacts

7893f28

ndegwamartin force-pushed the upgrade-sdk-libraries branch from 9139ea3 to 7893f28 Compare February 7, 2024 13:14

Merge branch 'main' into upgrade-sdk-libraries

26fae69

pld approved these changes Feb 7, 2024

View reviewed changes

ndegwamartin disabled auto-merge February 7, 2024 15:36

ndegwamartin enabled auto-merge (squash) February 7, 2024 15:44

ndegwamartin disabled auto-merge February 7, 2024 15:44

ndegwamartin merged commit f38ada8 into main Feb 7, 2024
4 of 6 checks passed

ndegwamartin deleted the upgrade-sdk-libraries branch February 7, 2024 15:51

This was referenced Feb 9, 2024

Measure Evaluate fails when generating reports for child indicators #3051

Closed

Test coverage for the Quest module not generated correctly. #3055

Open

Refactor Sync status handling to migrate to CurrentSyncJobStatus #3059

Closed

LZRS mentioned this pull request Feb 26, 2024

Add the SDC Location picker widget to the main branch #3046

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade sdk libraries to latest versions #2825

Upgrade sdk libraries to latest versions #2825

ellykits commented Oct 18, 2023 •

edited by ndegwamartin

Loading

ellykits commented Nov 1, 2023

ndegwamartin commented Feb 6, 2024

vitorpamplona commented Feb 6, 2024

ndegwamartin commented Feb 6, 2024

ndegwamartin commented Feb 7, 2024

Upgrade sdk libraries to latest versions #2825

Upgrade sdk libraries to latest versions #2825

Conversation

ellykits commented Oct 18, 2023 • edited by ndegwamartin Loading

ellykits commented Nov 1, 2023

ndegwamartin commented Feb 6, 2024

vitorpamplona commented Feb 6, 2024

ndegwamartin commented Feb 6, 2024

ndegwamartin commented Feb 7, 2024

ellykits commented Oct 18, 2023 •

edited by ndegwamartin

Loading