-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate HIV and TB registers to master-v1 #440
base: master-v1
Are you sure you want to change the base?
Conversation
gradle.properties
Outdated
@@ -1,4 +1,4 @@ | |||
VERSION_NAME=1.5.27-SNAPSHOT | |||
VERSION_NAME=1.5.27-alpha1-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the version we want to go with?
@@ -63,4 +85,37 @@ public void switchToBaseFragment() { | |||
public void startRegistration() { | |||
//implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be implemented in this PR? If not could we create a ticket to track this?
|
||
@Override | ||
protected void registerBottomNavigation() { | ||
//implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be implemented in this PR? If not could we create a ticket to track this?
public void initializeAdapter(@Nullable Set<? extends org.smartregister.configurableviews.model.View> visibleColumns) { | ||
CoreHivCommunityFollowupProvider hivCommunityRegisterProvider = new CoreHivCommunityFollowupProvider(getActivity(), visibleColumns, registerActionHandler, paginationViewHandler); | ||
clientAdapter = new RecyclerViewPaginatedAdapter(null, hivCommunityRegisterProvider, context().commonrepository(this.tablename)); | ||
clientAdapter.setCurrentlimit(20); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make this a constant i.e not hardcoded
@Override | ||
public void setAdvancedSearchFormData(HashMap<String, String> hashMap) { | ||
//TODO | ||
//Log.d(TAG, "setAdvancedSearchFormData unimplemented"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a ticket to track implementation of this
clientAdapter.setTotalcount(c.getInt(0)); | ||
Timber.v("total count here %s", clientAdapter.getTotalcount()); | ||
|
||
clientAdapter.setCurrentlimit(20); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to constants file
@Override | ||
public void setAdvancedSearchFormData(HashMap<String, String> hashMap) { | ||
//TODO | ||
//Log.d(TAG, "setAdvancedSearchFormData unimplemented"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track implementation of this.
@Override | ||
public void setAdvancedSearchFormData(HashMap<String, String> hashMap) { | ||
//TODO | ||
//Log.d(TAG, "setAdvancedSearchFormData unimplemented"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track implementation of this
|
||
@Override | ||
public void setAdvancedSearchFormData(HashMap<String, String> hashMap) { | ||
//TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track implementation of this
|
||
@Override | ||
public void setAdvancedSearchFormData(HashMap<String, String> hashMap) { | ||
//TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track this
|
||
@Override | ||
public void createReferralEvent(AllSharedPreferences allSharedPreferences, String jsonString, String entityID) throws Exception { | ||
//TODO implement this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a ticket to track this
try { | ||
List<BaseUpcomingService> baseUpcomingServices = new ArrayList<>(new CoreTbUpcomingServicesInteractor().getMemberServices(context, toMember(TbDao.getMember(baseEntityID)))); | ||
if (baseUpcomingServices.size() > 0) { | ||
Comparator<BaseUpcomingService> comparator = (o1, o2) -> o1.getServiceDate().compareTo(o2.getServiceDate()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have more descriptive variables for o1
and o2
|
||
@Override | ||
public void createReferralEvent(AllSharedPreferences allSharedPreferences, String jsonString, String entityID) throws Exception { | ||
//TODO implement this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track this
|
||
@Override | ||
public void refreshProfileTopSection(CommonPersonObjectClient client) { | ||
//implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track this or implement
|
||
@Override | ||
public void startFormForEdit(CommonPersonObjectClient client) { | ||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track this or implement the TODOs
|
||
@Override | ||
public void startFormForEdit(CommonPersonObjectClient client) { | ||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track this or implement the TODOs
@@ -58,6 +58,16 @@ protected void startMalariaRegister() { | |||
//TODO implement start malaria register for HF | |||
} | |||
|
|||
@Override | |||
protected void startHivRegister() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track this or implement
@@ -111,6 +111,16 @@ protected void goToFpProfile(String baseEntityId, Activity activity) { | |||
// TODO implement on HF | |||
} | |||
|
|||
@Override | |||
protected void goToHivProfile(String baseEntityId, Activity activity) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track this or implement
@@ -71,6 +71,16 @@ protected void startFpRegister() { | |||
//TODO implement start FP register for HF | |||
} | |||
|
|||
@Override | |||
protected void startHivRegister() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ticket to track this or implement
…and showing of Notification updates of these referrals
…ith regards to HIV profile and string resources
No description provided.