Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-runtime to v0.16.4 #413

Merged

Conversation

bshephar
Copy link
Contributor

This change updates controller-runtime and associated dependencies

@bshephar bshephar force-pushed the bump-controller-runtime branch from 53618b0 to dc96dd4 Compare February 1, 2024 13:09
@bshephar bshephar marked this pull request as ready for review February 1, 2024 13:09
@bshephar bshephar changed the title Update controller-runtime to v0.16.0 Update controller-runtime to v0.17.0 Feb 1, 2024
@bshephar bshephar force-pushed the bump-controller-runtime branch 6 times, most recently from 4547f61 to 3fca46d Compare February 2, 2024 22:30
@bshephar
Copy link
Contributor Author

bshephar commented Feb 4, 2024

Hmm, looks like the CI env isn't using Go 1.21:
https://github.com/openstack-k8s-operators/lib-common/actions/runs/7762273514/job/21172396751?pr=413#step:5:819

ERRO Running error: context loading failed: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: errors parsing go.mod:
/home/runner/work/lib-common/lib-common/modules/common/go.mod:5: unknown directive: toolchain 

@lewisdenny
Copy link

lewisdenny commented Feb 4, 2024

This is just using Github actions, not Prow or Zuul, the Github workflow will need to be updated AFAIU

https://github.com/openstack-k8s-operators/lib-common/blob/main/.github/workflows/golangci-lint.yaml#L13

@lewisdenny
Copy link

Updating that line in this PR should trigger the Github action to run with 1.21

@lewisdenny lewisdenny force-pushed the bump-controller-runtime branch from 3fca46d to 69fddd9 Compare February 5, 2024 00:08
@lewisdenny
Copy link

Added the Golang version override to the pre-commit job as well

@lewisdenny
Copy link

Nice that helped! 💚

@bshephar bshephar force-pushed the bump-controller-runtime branch from 69fddd9 to 620bad4 Compare February 12, 2024 06:51
@gibizer gibizer self-requested a review February 14, 2024 09:01
This change updates controller-runtime and associated dependencies
@bshephar bshephar force-pushed the bump-controller-runtime branch from 620bad4 to 80f6488 Compare February 14, 2024 13:03
@bshephar bshephar changed the title Update controller-runtime to v0.17.0 Update controller-runtime to v0.16.4 Feb 14, 2024
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abays abays merged commit dfabd44 into openstack-k8s-operators:main Feb 14, 2024
1 of 2 checks passed
@gibizer gibizer mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants