[service/route] allow updating labels and services #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with 18d0ea2 we introduced merging annotations and labels. It was required as other components can add annotations to a created service: ~~~ Author: Martin Schuppert <mschuppert@redhat.com> Date: Wed Sep 27 09:06:26 2023 +0200 Merge Annotations and Labels in CreateOrPatch Identified in OCP4.13 where metallb adds an annotation to the service when handling it, it resulted in reconcile loop since the current service CreateOrPatch did not expect that annotations will be altered outside the owner. This changes the different functions to merge Labels and Annotations in CreateOr Patch instead of assigning. ~~~ With the current order of how the labels on routes and services get created does not allow to change a value of an existing key as how the merge func works. This changes the order that existing labels and annotations of services and routes get merged so that those from an existing object gets merged into the one either provided via overrides or calculated by the operators. This still allows other components to add entries, and the operators/users to updated existing ones.
stuggi
added a commit
to stuggi/glance-operator
that referenced
this pull request
Jan 8, 2024
A route should get created for the glance-api instance which has - annotation with glance.KeystoneEndpoint -> true - it is the service.EndpointPublic - and the k8s service is corev1.ServiceTypeClusterIP Right now the service.AnnotationIngressCreateKey: "true" Annotation gets set on all glance-api services. Depends-On: openstack-k8s-operators/lib-common#432
stuggi
added a commit
to stuggi/glance-operator
that referenced
this pull request
Jan 8, 2024
A route should get created for the glance-api instance which has - annotation with glance.KeystoneEndpoint -> true - it is the service.EndpointPublic - and the k8s service is corev1.ServiceTypeClusterIP Right now the service.AnnotationIngressCreateKey: "true" Annotation gets set on all glance-api services. Depends-On: openstack-k8s-operators/lib-common#432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with 18d0ea2 we introduced merging annotations and labels. It was required as other components can add annotations to a created service:
With the current order of how the labels on routes and services get created does not allow to change a value of an existing key as how the merge func works.
This changes the order that existing labels and annotations of services and routes get merged so that those from an existing object gets merged into the one either provided via overrides or calculated by the operators. This still allows other components to add entries, and the operators/users to updated existing ones.