Add AddLabel()/AddAnnotation() for Route #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuggi
reviewed
Feb 5, 2024
There was a problem hiding this comment.
right, this needs tests as in https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/common/service/service_test.go#L479 . specify a default Route starting with no annotation, then:
- add a annotation
- add another annotation should have 2
- override an annotation (first one remains)
you could just make a copy of service.TestOverrideSpecAddAnnotation and change it for the Route use case.
elvgarrui
force-pushed
the
add_annotations_route
branch
from
281df61 to
2c3756f
Compare
stuggi
reviewed
Feb 12, 2024
Signed-off-by: Elvira García <egarciar@redhat.com>
elvgarrui
force-pushed
the
add_annotations_route
branch
from
2c3756f to
0a18b4f
Compare
elvgarrui
commented
Feb 16, 2024
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { |
There was a problem hiding this comment.
To be honest I'm aware this for on L71 might not needed yet, because I just described one route. However I thought I could leave this like that since we could expect this test to be expanded in a near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might need testing, but looking at similar PR (#418) I did not fully understand how I should create something similar to what we see there in "modules/common/service/service_test.go" for the Route struct.