Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing values for artwork_type #1443

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

okainov
Copy link

@okainov okainov commented Feb 10, 2025

Add some of the used and documented values from OSM wiki

Description, Motivation & Context

Some of the values which exist and in use are not available

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

https://taginfo.openstreetmap.org/keys/artwork_type#values

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Add some of the used and documented values from OSM wiki
@tyrasd tyrasd force-pushed the patch-1 branch 2 times, most recently from 71392bc to e41e600 Compare February 15, 2025 10:20
Copy link

🍱 You can preview the tagging presets of this pull request here.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyrasd
tyrasd previously approved these changes Feb 24, 2025
@tyrasd tyrasd dismissed stale reviews from matkoniecz and themself February 24, 2025 18:50

addressed

@tyrasd tyrasd added the waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on label Feb 24, 2025
@tyrasd tyrasd removed the waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants