Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset for amenity=veterinary_pharmacy #1451

Merged
merged 20 commits into from
Feb 26, 2025
Merged

Conversation

Avan2021
Copy link
Contributor

Description, Motivation & Context

This PR adds a preset for amenity=veterinary_pharmacy. While the current usage of this tag is relatively low, this is likely due to the lack of a dedicated preset, which makes it harder for mappers to tag these facilities. Veterinary pharmacies are distinct from regular pharmacies, specializing in medications for animals. A preset will improve tagging consistency and encourage more accurate mapping of these important amenities.

Related issues

Closes #1399

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dveterinary_pharmacy

Relevant tag usage stats:
Usage: 199

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@tordans
Copy link
Collaborator

tordans commented Feb 21, 2025

@Avan2021 the PR preview will be ready shortly. Please add the "Checklist and Test-Documentation Template" afterwards.

Copy link

🍱 You can preview the tagging presets of this pull request here.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below

tyrasd
tyrasd previously approved these changes Feb 24, 2025
@Avan2021
Copy link
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1451--ideditor-presets-preview.netlify.app/id/dist/#locale=en&disable_features=boundaries&map=20.00/23.04682/-82.46826&background=Bing&id=n5266821322

Screenshot 2025-02-25 100808

Search

Screenshot 2025-02-25 100825

Info-i

Screenshot 2025-02-25 100839

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@tordans
Copy link
Collaborator

tordans commented Feb 25, 2025

Thanks for adding the test documentation, @Avan2021, that helps a lot.

FYI: The part about the search should show the preset search which allows to see if the new preset will result in confusing search results given other presets. (You show the feature search which just lists the one feature on screen.)

image

==> Looks good

image

==> Less sure about this but this is more about why the "Pharmacy Counter" has this name. Does not matter too much, though, because name and icon make it clear which is which.

@tordans
Copy link
Collaborator

tordans commented Feb 25, 2025

I looked into (https://chatgpt.com/share/67bd5296-54e4-8010-b687-46c4d4dffed0 ) if there are any brand / chains in this area of shops and it turns out there are. ChatGPT also says some have drivethrough.

I therefore think we should base the fields for this preset on the preset https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/pharmacy.json#L3-L17

Will comment in line.

Avan2021 and others added 4 commits February 25, 2025 14:54
Adding "{amenity/pharmacy}" to fields

Co-authored-by: Tobias <t@tobiasjordans.de>
Adding "{amenity/pharmacy}" to moreFields

Co-authored-by: Tobias <t@tobiasjordans.de>
@Avan2021 Avan2021 requested a review from tordans February 25, 2025 09:33
Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We take all fields and moreFields from the other preset

@tordans
Copy link
Collaborator

tordans commented Feb 25, 2025

Could you please add a testing link that links to an OSM object that has the tags in question, so we can test this in a real live example. I suggest to create an overpass query for that and share that as well.

Avan2021 and others added 2 commits February 25, 2025 15:13
We take all fields and moreFields from other preset

Co-authored-by: Tobias <t@tobiasjordans.de>
We are taking all fields and more fields from other preset

Co-authored-by: Tobias <t@tobiasjordans.de>
@Avan2021 Avan2021 requested a review from tordans February 25, 2025 09:44
@Avan2021
Copy link
Contributor Author

Avan2021 commented Feb 25, 2025

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1451--ideditor-presets-preview.netlify.app/id/dist/#locale=en&disable_features=boundaries&id=n7892387549 //edit @tyrasd: replaced preview link with a feature that is actually tagged as veterinary_pharmacy
Screenshot 2025-02-25 100839

Search

Screenshot 2025-02-25 152449

Info-i

Screenshot 2025-02-25 152214

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@tyrasd tyrasd dismissed their stale review February 26, 2025 12:29

see @tordans follow-up review

@tyrasd

This comment was marked as off-topic.

@tordans tordans merged commit a2e4e42 into openstreetmap:main Feb 26, 2025
5 checks passed
@tordans
Copy link
Collaborator

tordans commented Feb 26, 2025

Thanks @Avan2021 . I checked that the moreFields work as inteted, which they do. This is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add preset for amenity=veterinary_pharmacy
3 participants