-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preset for amenity=veterinary_pharmacy #1451
Conversation
…ng-schema into groundskeeping
Added it wrongly
@Avan2021 the PR preview will be ready shortly. Please add the "Checklist and Test-Documentation Template" afterwards. |
🍱 You can preview the tagging presets of this pull request here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see below
Test-DocumentationPreview links & Sidebar ScreenshotsSearchInfo-
|
Thanks for adding the test documentation, @Avan2021, that helps a lot. FYI: The part about the search should show the preset search which allows to see if the new preset will result in confusing search results given other presets. (You show the feature search which just lists the one feature on screen.) ==> Looks good ==> Less sure about this but this is more about why the "Pharmacy Counter" has this name. Does not matter too much, though, because name and icon make it clear which is which. |
I looked into (https://chatgpt.com/share/67bd5296-54e4-8010-b687-46c4d4dffed0 ) if there are any brand / chains in this area of shops and it turns out there are. ChatGPT also says some have drivethrough. I therefore think we should base the fields for this preset on the preset https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/pharmacy.json#L3-L17 Will comment in line. |
Adding "{amenity/pharmacy}" to fields Co-authored-by: Tobias <t@tobiasjordans.de>
Adding "{amenity/pharmacy}" to moreFields Co-authored-by: Tobias <t@tobiasjordans.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We take all fields and moreFields from the other preset
Could you please add a testing link that links to an OSM object that has the tags in question, so we can test this in a real live example. I suggest to create an overpass query for that and share that as well. |
We take all fields and moreFields from other preset Co-authored-by: Tobias <t@tobiasjordans.de>
We are taking all fields and more fields from other preset Co-authored-by: Tobias <t@tobiasjordans.de>
Test-DocumentationPreview links & Sidebar Screenshotshttps://pr-1451--ideditor-presets-preview.netlify.app/id/dist/#locale=en&disable_features=boundaries&id=n7892387549 //edit @tyrasd: replaced preview link with a feature that is actually tagged as SearchInfo-
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Thanks @Avan2021 . I checked that the moreFields work as inteted, which they do. This is now merged. |
Description, Motivation & Context
This PR adds a preset for
amenity=veterinary_pharmacy
. While the current usage of this tag is relatively low, this is likely due to the lack of a dedicated preset, which makes it harder for mappers to tag these facilities. Veterinary pharmacies are distinct from regular pharmacies, specializing in medications for animals. A preset will improve tagging consistency and encourage more accurate mapping of these important amenities.Related issues
Closes #1399
Links and data
Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dveterinary_pharmacy
Relevant tag usage stats:
Usage: 199
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.