Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toilets as suggested tag for fast food places #1454

Merged
merged 17 commits into from
Feb 25, 2025

Conversation

Avan2021
Copy link
Contributor

Description, Motivation & Context

Lots of fast food places like McDonald's have toilets for customers, makes sense this tag should be added as an optional field.

Related issues

Closes #1391

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:toilets

Relevant tag usage stats:
Usage: 200,000+

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 You can preview the tagging presets of this pull request here.

@Avan2021 Avan2021 requested a review from tordans February 24, 2025 15:49
@Avan2021
Copy link
Contributor Author

Avan2021 commented Feb 24, 2025

Hi @tordans, this branch is based on an older one, hence the many commits. I'll create a fresh, clean branch and resubmit the PR shortly to avoid any issues. Sorry for the mess!

@tordans
Copy link
Collaborator

tordans commented Feb 24, 2025

Please force push instead.

@Avan2021
Copy link
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1454--ideditor-presets-preview.netlify.app/id/dist/#locale=en&disable_features=boundaries&map=20.00/13.77830/100.47776&background=Bing&id=n6274385901
Screenshot 2025-02-25 095603

Search

It is a suggested tag so there wasn't a clear way to show it in search
Screenshot 2025-02-25 095752

Info-i

Screenshot 2025-02-25 095603

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@tordans
Copy link
Collaborator

tordans commented Feb 25, 2025

Thanks for adding the test documentation @Avan2021 .

FYI in this case, the "search" section would reference the "moreFields" which is where I would need to go (search) to add this field

image

@tordans tordans merged commit b030d25 into openstreetmap:main Feb 25, 2025
5 checks passed
@tordans
Copy link
Collaborator

tordans commented Feb 25, 2025

Thanks for the PR @Avan2021 I just squash merged it in b030d25

For future PRs: Please rebase and force push them based on the latest main so we have a clean history in the PR. The squash merge will likely always handle any additional commits but I find it hard to be sure about that and its cleaner to have the PR only contain the commits that you add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toilets= as a suggested tag to amenity=fast_food.
3 participants