fix(select): [select] fix component error caused by vue2 deep cleanup memory leak #2843
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses a component error in the Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -36,7 +36,7 @@ const initState = ({ reactive, computed, props, api, markRaw, select, parent }) | |||
| disabled: computed(() => props.disabled || state.groupDisabled), | |||
| isObject: computed(() => Object.prototype.toString.call(props.value).toLowerCase() === '[object object]'), | |||
| currentLabel: computed(() => props.label || (state.isObject ? '' : props.value)), | |||
| currentValue: computed(() => props.value || props.label || ''), | |||
| currentValue: props.value || props.label || '', | |||
There was a problem hiding this comment.
The change from computed to a direct assignment for currentValue may lead to unexpected behavior if currentValue is expected to reactively update based on dependencies. Ensure that this change does not break reactive updates elsewhere in the component.
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
zzcr
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/renderless/src/option/vue.ts (1)
Line range hint
93-103: Consider extracting the object comparison logic.The complex object comparison logic for
valueKeycould be extracted into a separate function for better maintainability and reusability.+const isValueKeyEqual = (newVal, oldVal, valueKey) => { + return valueKey && + typeof newVal === 'object' && + typeof oldVal === 'object' && + newVal[valueKey] === oldVal[valueKey] +} watch( () => props.value, (value, oldVal) => { const { remote, valueKey } = select state.currentValue = value || props.label || '' if (!props.created && !remote) { - if ( - valueKey && - typeof value === 'object' && - typeof oldVal === 'object' && - value[valueKey] === oldVal[valueKey] - ) { + if (isValueKeyEqual(value, oldVal, valueKey)) { return }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/renderless/src/option/vue.ts(2 hunks)
🔇 Additional comments (2)
packages/renderless/src/option/vue.ts (2)
Line range hint
127-143: LGTM: Proper cleanup implementation.The cleanup implementation in
onBeforeUnmountis thorough and properly handles:
- Removal from cached options
- Event listener cleanup
- Select state updates
39-39: Verify all update scenarios with the simplified currentValue implementation.The change from a computed property to direct assignment helps reduce memory leaks by eliminating unnecessary watchers. However, we should verify that all update scenarios are properly handled, especially edge cases.
Let's verify the component's behavior in different scenarios:
✅ Verification successful
The currentValue implementation correctly handles all update scenarios
The simplified implementation with direct assignment and watch handler properly manages all value updates while reducing unnecessary watchers. The change is safe and aligned with the memory leak fix objective.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for all usages of currentValue to ensure we haven't missed any update scenarios rg "currentValue" --type ts # Look for potential test files that verify the component's behavior fd -e spec.ts -e test.ts "option"Length of output: 24701
| @@ -90,7 +90,7 @@ const initWatch = ({ watch, props, state, select, constants }) => { | |||
| () => props.value, | |||
| (value, oldVal) => { | |||
| const { remote, valueKey } = select | |||
|
|
|||
| state.currentValue = value || props.label || '' | |||
There was a problem hiding this comment.
Handle edge case where value is 0.
The fallback chain value || props.label || '' will treat 0 as falsy and fall back to props.label. This might not be the desired behavior if 0 is a valid value.
Consider this alternative implementation:
- state.currentValue = value || props.label || ''
+ state.currentValue = value != null ? value : props.label || ''📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| state.currentValue = value || props.label || '' | |
| state.currentValue = value != null ? value : props.label || '' |
PR
修复因为vue2深度清理内存泄漏导致的组件报错问题
Vue2.mixin({
destroyed(){
delete xxx
}
})
在深度清理时会删除vue实例的_watcher，导致computed建立的_watcher为undefined的报错
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
currentValueproperty