feat: remote proof bundles #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadeking98
force-pushed
the
feat-remote-proof-bundles
branch
from
41e2929 to
585dd58
Compare
cvarjao
reviewed
Nov 3, 2023
| } | ||
| return Promise.resolve(applyTemplateMarkers(templateData)) | ||
| } | ||
| return this.remoteServer.get('proof-templates.json').then((response) => { |
There was a problem hiding this comment.
how is this file being cached?
There was a problem hiding this comment.
right now it's just saving the templates in temporary memory, I'm going to implement saving the templates to local storage
There was a problem hiding this comment.
so right now it will fetch the templates once when is starts up, but I'll implement some caching
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
wadeking98
force-pushed
the
feat-remote-proof-bundles
branch
from
6a2deb2 to
942b833
Compare
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
+ Coverage 60.92% 61.12% +0.19%
==========================================
Files 180 181 +1
Lines 5444 5520 +76
Branches 1559 1571 +12
==========================================
+ Hits 3317 3374 +57
- Misses 2103 2122 +19
Partials 24 24
|
|
Juat curious, should can this go in its own package. |
Personally I feel it's a bit small for it's own package and I don't think it would be used outside of bifold |
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
bryce-mcmath
requested changes
Nov 8, 2023
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
…ng98/aries-mobile-agent-react-native into feat-remote-proof-bundles
bryce-mcmath
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added ability to fetch remote proof bundles rather than using hardcoded values.
Note: to use remote proof bundles set the following variable in your .env file
PROOF_TEMPLATE_URL=https://raw.githubusercontent.com/wadeking98/bc-wallet-mobile/proof-template-bundle/Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.