-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OpenId4VC support #1604
feat: OpenId4VC support #1604
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
- Coverage 85.76% 77.29% -8.47%
==========================================
Files 951 926 -25
Lines 22854 22853 -1
Branches 4017 4115 +98
==========================================
- Hits 19601 17665 -1936
- Misses 3069 4835 +1766
- Partials 184 353 +169
|
150cc9b
to
43a1676
Compare
} | ||
|
||
// what does this mean | ||
const openId4VcCredentialMetadataKey = '_paradym/openId4VcCredentialMetadata' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a storage key that can be used to retrieve metadata about the credential. Likely for ease of access for displaying. @TimoGlastra likely knows whether we have to keep an equivalent or if this is up to the user to define.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is not yet finished. Just pushed some progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the display / issuer metadata. I chose to not add it as PR in AFJ as the spec is continuously evolving and thus it will contain different structures in the metadata. Not sure if that's a problem. It is very useful to have this though, but it may be better if we can generalize it and create a universal credential display format (not sure what OCA uses for this) with something like https://identity.foundation/wallet-rendering/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am implementing OpenID4VCI in our wallet and in Bifold in the mean time, this PR is a life saver since am not able to use Spheroin for testing with current package version. @TimoGlastra any suggestions on a good testbed (issuer)that supports older draft to use for development until this PR is merged?
For OCA, it will be nice if there is an option to inject an OCA bundle identifier into one of the attributes to use it later for fetching OCA layers for that specific VC. The whole thing is running perfectly in Bifold with the option to remote fetch OCA bundles, the missing part is AFJ handling that as part of credential attributes instead of manually matching with credential/schema ids. Could discuss further
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MosCD3 for draft 8 you can I think use https://jff.walt.id/ and for draft 11 you can use https://launchpad.mattrlabs.com/
94771a2
to
65f6e5b
Compare
bc4d47d
to
ed1641b
Compare
eaa8e82
to
ee8753e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @2mau!!! I think there is some cleanup to do, but thats always expected with such a big PR.
packages/openid4vc-holder/src/issuance/OpenId4VciHolderService.ts
Outdated
Show resolved
Hide resolved
ee8753e
to
6eeee9a
Compare
packages/openid4vc-holder/src/issuance/OpenId4VciHolderService.ts
Outdated
Show resolved
Hide resolved
packages/openid4vc-holder/src/presentations/OpenId4VpHolderService.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some minor comments, but nothing blocking from my side.
062434c
to
136377e
Compare
136377e
to
a641a96
Compare
No description provided.