Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenId4Vc Support #1639

Closed

Conversation

auer-martin
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 407 lines in your changes are missing coverage. Please review.

Comparison is base (a641a96) 62.69% compared to head (648d59e) 60.45%.

Files Patch % Lines
...r/src/presentations/PresentationExchangeService.ts 3.46% 152 Missing and 15 partials ⚠️
.../presentations/selection/PexCredentialSelection.ts 6.45% 79 Missing and 8 partials ⚠️
...4vc-holder/src/issuance/OpenId4VciHolderService.ts 80.14% 51 Missing and 2 partials ⚠️
...holder/src/presentations/OpenId4VpHolderService.ts 45.67% 41 Missing and 3 partials ⚠️
...es/openid4vc-holder/src/presentations/transform.ts 17.24% 24 Missing ⚠️
...vc-holder/src/issuance/utils/claimFormatMapping.ts 46.15% 14 Missing ⚠️
...c-holder/src/issuance/utils/IssuerMetadataUtils.ts 87.01% 10 Missing ⚠️
...ackages/openid4vc-holder/src/OpenId4VcHolderApi.ts 88.00% 3 Missing ⚠️
...ges/openid4vc-holder/src/issuance/utils/Formats.ts 83.33% 3 Missing ⚠️
...odules/vc/data-integrity/SignatureSuiteRegistry.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1639      +/-   ##
==========================================
- Coverage   62.69%   60.45%   -2.24%     
==========================================
  Files         779      751      -28     
  Lines       18128    17096    -1032     
  Branches     3128     3050      -78     
==========================================
- Hits        11365    10336    -1029     
+ Misses       6219     6183      -36     
- Partials      544      577      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbluhm
Copy link
Contributor

dbluhm commented Nov 19, 2023

We're eager to use these changes to test against an ACA-Py plugin we're building for OpenID4VCI.

@TimoGlastra
Copy link
Contributor

We're eager to use these changes to test against an ACA-Py plugin we're building for OpenID4VCI.

Cool @dbluhm! Which format profiles are you supporting? We're focussing on JWT / SD-JWT for now

@dbluhm
Copy link
Contributor

dbluhm commented Nov 22, 2023

We're definitely taking an iterative approach but we're focusing on JWT first. SD-JWTs will likely come next. We've been testing against the sphereon wallet and I believe this is using the Sphereon SDK so hopefully that bodes well for compatibility!

Are you basing the SD-JWT format off of the HAIP? That's the only place I've seen it defined so far but there are some restrictions in that profile we're not thrilled about.

@TimoGlastra
Copy link
Contributor

Are you basing the SD-JWT format off of the HAIP? That's the only place I've seen it defined so far but there are some restrictions in that profile we're not thrilled about.

Yes we're basing it off haip

Which restrictions are you not so thrilled about? I think our main concern was did support, but the spec recommends to use jwk, but you can use other ways to bind the credential to e.g. a did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants