Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move message-pickup directory #1650

Merged

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Nov 27, 2023

For some strange reason, the 'i' in message-pickup module directory is an special character, which makes it difficult to create patches to properly test updates in that module (like the ones in #1638), so this small PR is just fixing it using a regular 'i'.

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team as a code owner November 27, 2023 12:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c59ad59) 55.81% compared to head (adcc963) 84.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1650       +/-   ##
===========================================
+ Coverage   55.81%   84.83%   +29.02%     
===========================================
  Files         664      972      +308     
  Lines       14981    23619     +8638     
  Branches     2597     4168     +1571     
===========================================
+ Hits         8362    20038    +11676     
+ Misses       6098     3375     -2723     
+ Partials      521      206      -315     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's funny :)

@TimoGlastra TimoGlastra merged commit 4c08179 into openwallet-foundation:main Nov 27, 2023
7 checks passed
genaris added a commit to genaris/credo-ts that referenced this pull request Dec 4, 2023
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
genaris added a commit to genaris/credo-ts that referenced this pull request Jan 29, 2024
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants