Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude test types from core #2167

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Jan 30, 2025

In Core we are including test types in the source code, and since now we have dependency on DIDComm module it was messing up the core package build process (it creates 2 directories, one with core and another with didcomm).

Thanks @sairanjit for noticing and showing the solution for this!

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team as a code owner January 30, 2025 19:04
Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: 9790e0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and since now we have dependency on DIDComm module

Does core depend on didcomm?

@genaris
Copy link
Contributor Author

genaris commented Jan 30, 2025

and since now we have dependency on DIDComm module

Does core depend on didcomm?

By mistake, due to this jest types file that I'm excluding here.

@genaris genaris merged commit a0f0574 into openwallet-foundation:main Jan 31, 2025
24 checks passed
@genaris genaris deleted the fix/core-build branch January 31, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants