Tweaks for the PG problem editor for course info files. #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
course-info-edit-tweaks
branch
from
ccd7550 to
f8b29d1
Compare
This wraps the injected course info html in a `div` that has overflow auto set. If the course info file has long contents, then those contents currently extend past the containing div, and this fixes that. In addition padding and a background color are added to improve the appearance. These are the same styles that are used when this is displayed in the actual info box.
drgrice1
force-pushed
the
course-info-edit-tweaks
branch
from
f8b29d1 to
8bc52de
Compare
drdrew42
approved these changes
Nov 20, 2023
pstaabp
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps the injected course info html in a
divthat has overflow auto set. If the course info file has long contents, then those contents currently extend past the containing div, and this fixes that. This was observed by @drdrew42 in the meeting today.In addition padding and a background color are added to improve the appearance. These are the same styles that are used when this is displayed in the actual info box.