Check library against django 4.1/4.2 #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have ran the tests localy with |
nemesifier
requested changes
Nov 1, 2023
gbip
force-pushed
the
upgrade_django
branch
3 times, most recently
from
bf47aa2 to
e9d22c0
Compare
Done. Some tests are failing (django v3.0 and v4.2), it seems that it's an old psycopg2 bug : psycopg/psycopg2#1293 I had to remove the version constraint on psycopg2 because pip could not resolve the dependency graph for django 4.2. |
|
I wasn't able to look into it, yet but we'll fix asap. |
|
need the failing tests to pass |
|
Solved in #303. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.