Use device duck typing for empty device lists #22667
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_726233342
branch
5 times, most recently
from
c36995b to
cb3998b
Compare
We are soon going to require all IFRT users to use `Client::MakeDeviceList()` to create a device list instead of calling `BasicDeviceList::Create()`. `PyDeviceList(nb::tuple py_device_assignment)` with an empty device assignment cannot infer the IFRT client to use, so it seems the simplest to fall back to device duck typing like we already do for device lists with devices from multiple clients. PiperOrigin-RevId: 726470637
copybara-service
bot
force-pushed
the
test_726233342
branch
from
cb3998b to
b195247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use device duck typing for empty device lists
We are soon going to require all IFRT users to use
Client::MakeDeviceList()to create a device list instead of callingBasicDeviceList::Create().PyDeviceList(nb::tuple py_device_assignment)with an empty device assignment cannot infer the IFRT client to use, so it seems the simplest to fall back to device duck typing like we already do for device lists with devices from multiple clients.