PR #22640: [NFC] Deduplicate functions between HLO runners. #22683
+43
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_726395897
branch
2 times, most recently
from
b884661 to
c0bbb00
Compare
Imported from GitHub PR #22640 Copybara import of the project: -- e0e1de4 by Ilia Sergachev <isergachev@nvidia.com>: [NFC] Deduplicate functions between HLO runners. -- aeff13d by Ilia Sergachev <isergachev@nvidia.com>: [NFC] Delete unused functions. -- c073163 by Ilia Sergachev <1894984+sergachev@users.noreply.github.com>: Update xla/service/hlo_runner_interface.cc Co-authored-by: Allan Renucci <allanrenucci@users.noreply.github.com> -- b043017 by Ilia Sergachev <1894984+sergachev@users.noreply.github.com>: Update xla/service/hlo_runner_interface.h Co-authored-by: Allan Renucci <allanrenucci@users.noreply.github.com> -- 48383f2 by Ilia Sergachev <1894984+sergachev@users.noreply.github.com>: Update xla/service/hlo_runner_interface.h Co-authored-by: Allan Renucci <allanrenucci@users.noreply.github.com> -- d5bca65 by Ilia Sergachev <isergachev@nvidia.com>: Rename HloProtoToModule to CreateModuleFromProto for consistency. -- be158dd by Ilia Sergachev <1894984+sergachev@users.noreply.github.com>: Update xla/service/hlo_runner_interface.h Co-authored-by: Allan Renucci <allanrenucci@users.noreply.github.com> -- e34efb4 by Ilia Sergachev <1894984+sergachev@users.noreply.github.com>: Update xla/service/hlo_runner_interface.h Co-authored-by: Allan Renucci <allanrenucci@users.noreply.github.com> Merging this change closes #22640 FUTURE_COPYBARA_INTEGRATE_REVIEW=#22640 from openxla:cleanup_hlo_functions e34efb4 PiperOrigin-RevId: 726395897
copybara-service
bot
force-pushed
the
test_726395897
branch
from
c0bbb00 to
fd8eb05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #22640: [NFC] Deduplicate functions between HLO runners.
Imported from GitHub PR #22640
Copybara import of the project:
--
e0e1de4 by Ilia Sergachev isergachev@nvidia.com:
[NFC] Deduplicate functions between HLO runners.
--
aeff13d by Ilia Sergachev isergachev@nvidia.com:
[NFC] Delete unused functions.
--
c073163 by Ilia Sergachev 1894984+sergachev@users.noreply.github.com:
Update xla/service/hlo_runner_interface.cc
Co-authored-by: Allan Renucci allanrenucci@users.noreply.github.com
b043017 by Ilia Sergachev 1894984+sergachev@users.noreply.github.com:
Update xla/service/hlo_runner_interface.h
Co-authored-by: Allan Renucci allanrenucci@users.noreply.github.com
48383f2 by Ilia Sergachev 1894984+sergachev@users.noreply.github.com:
Update xla/service/hlo_runner_interface.h
Co-authored-by: Allan Renucci allanrenucci@users.noreply.github.com
d5bca65 by Ilia Sergachev isergachev@nvidia.com:
Rename HloProtoToModule to CreateModuleFromProto for consistency.
--
be158dd by Ilia Sergachev 1894984+sergachev@users.noreply.github.com:
Update xla/service/hlo_runner_interface.h
Co-authored-by: Allan Renucci allanrenucci@users.noreply.github.com
e34efb4 by Ilia Sergachev 1894984+sergachev@users.noreply.github.com:
Update xla/service/hlo_runner_interface.h
Co-authored-by: Allan Renucci allanrenucci@users.noreply.github.com
Merging this change closes #22640
FUTURE_COPYBARA_INTEGRATE_REVIEW=#22640 from openxla:cleanup_hlo_functions e34efb4