Skip to content

ZTS: Stop zpool_status tests from spamming stdout #17292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

ZTS: Stop zpool_status tests from spamming stdout #17292

merged 1 commit into from
May 2, 2025

Conversation

tonyhutter
Copy link
Contributor

Motivation and Context

Remove 20MB of ZTS log spam

Description

zpool_status_003 and zpool_status_004_pos use dd to trigger a read of a file without specifying of=/dev/null. This spams the ZTS logs with ~20MB of garbage data. This commit adds of=/dev/null.

How Has This Been Tested?

CI tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@tonyhutter
ZTS: Stop zpool_status tests from spamming stdout
f40721b 
zpool_status_003 and zpool_status_004_pos use 'dd' to trigger a read of
a file without specifying 'of=/dev/null'.  This spams the ZTS logs
with ~20MB of garbage data. This commit adds 'of=/dev/null'.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label May 2, 2025
@tonyhutter tonyhutter merged commit a6cca8a into openzfs:master May 2, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmilk mcmilk mcmilk approved these changes

@gmelikov gmelikov gmelikov approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyhutter @mcmilk @gmelikov @amotin