Docker Documentation in README.md issue #228 #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
end-9214
changed the title
benoit74
force-pushed
the
update-readme-docker
branch
from
d837a81 to
4651b02
Compare
|
We prefer you rebase on main, not merge main in your branch. Fixed commit message as well. |
benoit74
approved these changes
Mar 10, 2025
|
And your first comment on this PR is not properly linking this PR to solved issue |
|
Thanks @benoit74 . I will keep that in mind for future :D my 2nd PR merged :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #228
@benoit74 I sorry , I closed the previous PR while merging the incoming updates in my Forked repo. Please check if there are any mistakes.