Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of metadata and build plugins #1

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jan 9, 2024

Rationale

For openzim/_python-bootstrap#35:

  • Implement a metadata plugin which will populates common OpenZIM metadata according to our conventions
  • Implement a build plugin which for now allows to install external dependencies (e.g. JS files)

⚠️ Trusted publishing must be set up ⚠️

@benoit74 benoit74 self-assigned this Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@benoit74 benoit74 requested a review from rgaudin January 9, 2024 10:12
@benoit74 benoit74 marked this pull request as draft January 12, 2024 09:26
@benoit74
Copy link
Collaborator Author

Converting to draft because this is still missing some parts in the "build" hook:

  • the check that file is already installed to not redo it many times for nothing
  • the call to a custom tool to patch files installed (e.g. fixogvjs)

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good ; I know it's in draft and you'll add stuff but at least this part is already reviewed.

@benoit74 benoit74 marked this pull request as ready for review January 23, 2024 10:34
@benoit74 benoit74 requested a review from rgaudin January 23, 2024 10:34
@benoit74
Copy link
Collaborator Author

In fact, I propose to merge it like it is, anyway it works well but just has two missing features for which I have to ask questions, so I will open dedicated issues.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's merge and open tickets

@rgaudin rgaudin merged commit 456a3f1 into main Jan 23, 2024
9 checks passed
@rgaudin rgaudin deleted the initial_version branch January 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants