Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last changes before v0.1 #5

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Last changes before v0.1 #5

merged 9 commits into from
Feb 5, 2024

Conversation

benoit74
Copy link
Collaborator

Rationale

Fix #3
Fix #4

@benoit74 benoit74 self-assigned this Jan 25, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (456a3f1) 100.00% compared to head (2a53c06) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          199       216   +17     
  Branches        56        61    +5     
=========================================
+ Hits           199       216   +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 changed the title Last changes before v1 Last changes before v0.1 Jan 25, 2024
@benoit74 benoit74 marked this pull request as ready for review January 25, 2024 14:58
@benoit74 benoit74 requested a review from rgaudin January 25, 2024 14:58
rgaudin
rgaudin requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we currently have a need for this execute_after feature? Is this only for this ogv.js patch thing?

@benoit74
Copy link
Collaborator Author

Do we currently have a need for this execute_after feature? Is this only for this ogv.js patch thing?

Yes it is the only use-case for now AFAIK

@benoit74 benoit74 requested a review from rgaudin January 25, 2024 17:19
@rgaudin
Copy link
Member

rgaudin commented Jan 26, 2024

Do we currently have a need for this execute_after feature? Is this only for this ogv.js patch thing?

Yes it is the only use-case for now AFAIK

OK, I was a bit scared by the examples (mkdir, etc) 😉

rgaudin
rgaudin requested changes Jan 26, 2024
View reviewed changes
@benoit74 benoit74 requested a review from rgaudin January 26, 2024 13:35
@benoit74 benoit74 mentioned this pull request Feb 2, 2024
Merged
rgaudin
rgaudin approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit b3a821f into main Feb 5, 2024
9 checks passed
@benoit74 benoit74 deleted the complete_v1 branch February 5, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build hook: allow execution of arbitrary commands Build hook: do not reinstall file if already present
2 participants
@benoit74 @rgaudin