-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to python3.13 and other dependencies #133
Upgrade to python3.13 and other dependencies #133
Conversation
|
I had to add it because when I ran |
I fixed it now. Sorry if I'm stressing you 🙏 |
560f64b
to
bd159ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 50.92% 50.92%
=======================================
Files 20 20
Lines 1186 1186
Branches 137 137
=======================================
Hits 604 604
Misses 569 569
Partials 13 13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments for small changes + CI is failing, the Dockerfile
base image needs to be updated to use Python 3.13 as well (it wasn't specified in the issue tbh).
scraper/pyproject.toml
Outdated
lint = ["black==24.10.0", "ruff==0.9.1"] | ||
check = ["pyright==1.1.391"] | ||
lint = ["black==25.1.0", "ruff==0.9.5"] | ||
check = ["pyright==1.1.393"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since pytest
is needed for check
operations to run, then please add it back here (my question is only a question to understand things as fast as possible avoiding to have to explore things you've already understood). Or even better, add mindtouch2zim[test]
to avoid repeating the pytest version.
scraper/pyproject.toml
Outdated
build-backend = "hatchling.build" | ||
|
||
[project] | ||
name = "mindtouch2zim" | ||
requires-python = ">=3.12,<3.13" | ||
requires-python = ">=3.13,<3.14" # require python 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment, it should be obvious to most developpers
scraper/pyproject.toml
Outdated
description = "Make ZIM file from Mindtouch / Nice CXone Expert libraries" | ||
readme = "../README.md" | ||
dependencies = [ | ||
"zimscraperlib==5.0.0", | ||
"zimscraperlib==5.1.0", # upgrade to 5.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment, it means nothing outside this PR
bd159ed
to
df79423
Compare
df79423
to
097f298
Compare
fix #132
Ready for review