Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Context class, pass User-Agent to all web requests, set async job timeout, and retry header retrieval #92

Merged
merged 8 commits into from
Dec 6, 2024

Fix integration tests

34b596f
Select commit
Loading
Failed to load commit list.
Merged

Add Context class, pass User-Agent to all web requests, set async job timeout, and retry header retrieval #92

Fix integration tests
34b596f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 6, 2024 in 0s

49.42% (+5.76%) compared to d63320e

View this Pull Request on Codecov

49.42% (+5.76%) compared to d63320e

Details

Codecov Report

Attention: Patch coverage is 63.10160% with 69 lines in your changes missing coverage. Please review.

Project coverage is 49.42%. Comparing base (d63320e) to head (34b596f).

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 23.07% 30 Missing ⚠️
scraper/src/mindtouch2zim/__main__.py 0.00% 15 Missing ⚠️
scraper/src/mindtouch2zim/asset.py 23.52% 13 Missing ⚠️
scraper/src/mindtouch2zim/client.py 36.36% 7 Missing ⚠️
scraper/src/mindtouch2zim/download.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   43.66%   49.42%   +5.76%     
==========================================
  Files          15       17       +2     
  Lines         987     1050      +63     
  Branches      133      147      +14     
==========================================
+ Hits          431      519      +88     
+ Misses        545      520      -25     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.