Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove traces of camelCase in API #212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove traces of camelCase in API #212

wants to merge 2 commits into from

Conversation

elfkuzco
Copy link
Contributor

Rationale

Use snake case for all the API methods and parameters. This resolves #200

Changes

  • Convert camelCase method names and parameters in Python interface to snake case

rgaudin
rgaudin requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the changelog patch. Otherwise it's all good.

@elfkuzco elfkuzco requested a review from rgaudin December 2, 2024 17:11
@kelson42
Copy link
Contributor

kelson42 commented Dec 3, 2024

I guess if we merge this PR, next release has to be 4.0.0?

@rgaudin
Copy link
Member

rgaudin commented Dec 4, 2024

I guess if we merge this PR, next release has to be 4.0.0?

Yes

@rgaudin rgaudin mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[next-major] Remove traces of CamelCase
3 participants
@elfkuzco @kelson42 @rgaudin