Skip to content

Commit

Permalink
Merge pull request #175 from elfkuzco/resolve-sort-languages-hack
Browse files Browse the repository at this point in the history
fix issue with sort_language_hack returning None
  • Loading branch information
benoit74 authored Mar 28, 2024
2 parents d57d160 + de6ad9e commit ed322db
Showing 1 changed file with 15 additions and 16 deletions.
31 changes: 15 additions & 16 deletions src/ted2zim/scraper.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,24 +106,23 @@ def sort_languages_hack(languages: set[str]) -> list[str]:
For now, if eng is among the list, we assume it is the most important
language. Otherwise list is kept as-is
"""
return list(languages).sort(
key=lambda x: -1 if x == "eng" else 0
) # pyright: ignore[reportReturnType]
return sorted(languages, key=lambda x: -1 if x == "eng" else 0)

if not self.languages:
self.zim_languages = "eng"
else:
self.zim_languages = ",".join(
sort_languages_hack(
{
lang
for lang in [
get_iso_639_3_language(lang) for lang in self.languages
]
if lang
}
)
self.zim_languages = ",".join(
sort_languages_hack(
{
lang
for lang in [
get_iso_639_3_language(lang) for lang in self.languages
]
if lang
}
)
)

if not self.zim_languages:
self.zim_languages = "eng"

self.tags = [] if tags is None else [tag.strip() for tag in tags.split(",")]
self.tags = [*self.tags, "_category:ted", "ted", "_videos:yes"]
self.title = title
Expand Down

0 comments on commit ed322db

Please sign in to comment.