Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publisher metadata from 'Kiwix' to 'openZIM' #165

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Update publisher metadata from 'Kiwix' to 'openZIM' #165

merged 3 commits into from
Mar 8, 2024

Conversation

dan-niles
Copy link
Contributor

@dan-niles dan-niles commented Mar 6, 2024

Rationale

Resolves #159

Changes

Updated the publisher metadata from 'Kiwix' to 'openZIM' in entrypoint.py

@benoit74 benoit74 self-requested a review March 7, 2024 09:18
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (253b5ec) to head (e3d2629).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #165   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        945     945           
  Branches     218     218           
=====================================
  Misses       945     945           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to CHANGELOG.md, in the "Unreleased" section (you will have to added either a "Fixed" or "Changed" subsection, not sure which one is more appropriate, I let you choose, it is not that important anyway)

@dan-niles
Copy link
Contributor Author

Updated CHANGELOG.md in 575e6e4

@dan-niles dan-niles requested a review from benoit74 March 8, 2024 05:37
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

CHANGELOG.md Outdated
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

## [2.1.1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not add a version number yet, we keep everything in the ## Unreleased section until we know where it will be released (could be a patch release if we decide to release a patch, or a minor, or a major, this is not known yet).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, I'll remove it.

@dan-niles dan-niles requested a review from benoit74 March 8, 2024 09:07
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit e5c6401 into openzim:main Mar 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonize default publisher to openZIM
2 participants