-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update publisher metadata from 'Kiwix' to 'openZIM' #165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 7 7
Lines 945 945
Branches 218 218
=====================================
Misses 945 945 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry to CHANGELOG.md, in the "Unreleased" section (you will have to added either a "Fixed" or "Changed" subsection, not sure which one is more appropriate, I let you choose, it is not that important anyway)
Updated CHANGELOG.md in 575e6e4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change
CHANGELOG.md
Outdated
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## Unreleased | |||
|
|||
## [2.1.1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not add a version number yet, we keep everything in the ## Unreleased
section until we know where it will be released (could be a patch release if we decide to release a patch, or a minor, or a major, this is not known yet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rationale
Resolves #159
Changes
Updated the publisher metadata from 'Kiwix' to 'openZIM' in entrypoint.py