Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is kind of a fix to #165.
The root issue seems that vimeo is using js module (instead of plain "classic" script) and rewriter is not detecting thing correctly.
If it is somehow easily fixable for inline module, we have to detect that for js resources themselves. We have regex in JS rewriter to detect that, but it seems it is not working. The check
works in our use case, but probably (definitively?) not something we want in production.
I'm still searching for a good way to detect that.
For wabac.js, it is easier as js is rewritten as runtime, so it knows the context.
On top of that, the player seems to be broken sometime, depending if you are clicking on the "video background" or the "play" button. Alternate clicking on video/play button launch the video.