Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.12, upgrade Python dependencies and add hatch-openzim plugin #286

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Mar 1, 2024

Maintenance work:

  • Upgrade to Python 3.12
    • since our Docker image is based on browsertrix-crawler (Dockerfile) which is based on browsertrix-browser-base (Dockerfile) which is for now based on Ubuntu Jammy
    • since Ubuntu Jammy does not provides Python 3.12 apt packages
    • I had to add the deadsnakes PPA (which is a recommendable PPA team)
  • Upgrade dependencies
    • ruff 0.3 has deprecated ruff --fix in favor of ruff check --fix
  • Adopt hatch-openzim plugin for metadata handling

@benoit74 benoit74 self-assigned this Mar 1, 2024
@benoit74 benoit74 changed the base branch from main to zimit2 March 1, 2024 13:50
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.88%. Comparing base (9244f2e) to head (857ae56).
Report is 4 commits behind head on zimit2.

Additional details and impacted files
@@            Coverage Diff             @@
##           zimit2     #286      +/-   ##
==========================================
- Coverage   15.00%   14.88%   -0.12%     
==========================================
  Files           1        1              
  Lines         260      262       +2     
  Branches       40       38       -2     
==========================================
  Hits           39       39              
- Misses        221      223       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review March 1, 2024 14:07
@benoit74 benoit74 requested a review from rgaudin March 1, 2024 14:07
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very comfortable with using a ppa for python but I guess it's the most practical thing to do at this point

@benoit74
Copy link
Collaborator Author

benoit74 commented Mar 4, 2024

Would you prefer to install from source ? Not that complex, see e.g. https://ubuntuhandbook.org/index.php/2021/10/compile-install-python-3-10-ubuntu/.

I prefer the PPA because it is easier to read and maintain (no need to update download link every patch release), but if it is a concern I can switch to install from source.

@rgaudin
Copy link
Member

rgaudin commented Mar 4, 2024

As I wrote, it's the most practical at this point. Trusting deadsnakes is a better use of our time

@benoit74 benoit74 merged commit c2dc8c5 into zimit2 Mar 4, 2024
5 of 6 checks passed
@benoit74 benoit74 deleted the upgrade_deps branch March 4, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants