Keep temporary folder when crawler or warc2zim fails, even if not asked for

[benoit74]

Fix #468

[rgaudin]

I don't see cleanup being registered anywhere.

Also I find it an additional, burden on user's hand to have to manually cleanup.
At the very minimum, we should expose this new behavior in usage ; maybe in the --keep section as the sole presence of a --keep would let people think that not using it doesnt leave stuff behind.

[benoit74]

I don't see cleanup being registered anywhere.

https://github.com/openzim/zimit/pull/470/files#diff-1deb66886548313e10283b476c77ee7b31991f38265c18cdca62daea9859a8bbR457

Also I find it an additional, burden on user's hand to have to manually cleanup.

I agree, it is an additional burden. But at the same time, loosing WARC files which could have taken days to build just because warc2zim fails due to a missing configuration is a bit hard as well. Users should have seen the --keep, but you never know in advance if the run will fail or not, and passing --keep systematically means that you always have to cleanup ... not really better.

At the very minimum, we should expose this new behavior in usage ; maybe in the --keep section as the sole presence of a --keep would let people think that not using it doesnt leave stuff behind.

Agreed, documentation of this PR is insufficient.

[rgaudin]

Thank you