Enhance support of Browsertrix Crawler arguments #471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #416
Fix #433
--noMobileDevice
setting (not needed anymore)--seedFile
being a URL instead of a local filezimit_args
are not args for zimit but for the crawler or shared, hence better namedknown_args
get_node_cmd_line
=>get_crawler_cmd_line
(crawler is indeed in node, but who cares?)Due to multiple breaking changes, this will require a major version
Probably better to review commit by commit.