Skip to content

Commit

Permalink
kafka spancollector documentation update
Browse files Browse the repository at this point in the history
Fix documentation on how spans are transferred to Kafka.
  • Loading branch information
kristofa committed Dec 31, 2015
1 parent 4a61a69 commit d81a55e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions brave-spancollector-kafka/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

SpanCollector that is used to submit spans to Kafka.

Spans are sent to kafka as keyed messages: the key is the topic `zipkin`
and the value is a TBinaryProtocol encoded Span.
Spans are sent to a topic named `zipkin` and contain no key or partition only a value which is a TBinaryProtocol encoded Span.

## Monitoring ##

Expand All @@ -13,4 +12,4 @@ counters in your metrics tool. When a span gets dropped, the reason is written t
The number of spans sent to the target collector can be calculated by subtracting the dropped count from the accepted count.

Refer to `DropwizardMetricsSpanCollectorMetricsHandlerExample` for an example of how to integrate with
[dropwizard metrics](https://github.com/dropwizard/metrics).
[dropwizard metrics](https://github.com/dropwizard/metrics).

0 comments on commit d81a55e

Please sign in to comment.