Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cassandra: adds CASSANDRA_SSL_HOSTNAME_VALIDATION #3701

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

codefromthecrypt
Copy link
Member

This adds CASSANDRA_SSL_HOSTNAME_VALIDATION with the same behavior as defined in cassandra's SSL_HOSTNAME_VALIDATION, with the same default value of true.

Thanks @priyavivek2307 for starting this on #3457. I tried to re-use that PR, but it was too old and github closed it when I tried to rebase. Thanks also to @ankit-gautam23 for the review.

Priya Sharma and others added 4 commits January 23, 2024 13:12
@@ -115,31 +115,6 @@ zipkin:
mem:
# Maximum number of spans to keep in memory. When exceeded, oldest traces (and their spans) will be purged.
max-spans: ${MEM_MAX_SPANS:500000}
cassandra:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this was still in our yaml, though being dead for years, so I removed it.

@codefromthecrypt
Copy link
Member Author

flake is unrelated and I'll sort it out today or tomorrow. Seems a race and odd that awaitility isn't solving it..

 05:28:55,361 INFO  [armeria-common-worker-epoll-2-3] eureka.EurekaUpdatingListener (EurekaUpdatingListener.java:175) - Registered fv-az532-522 to Eureka: http://localhost:32770/eureka/v2
Error:  Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.12 s <<< FAILURE! -- in zipkin2.server.internal.eureka.ITZipkinEureka
Error:  zipkin2.server.internal.eureka.ITZipkinEureka.registersInEureka -- Time elapsed: 0.176 s <<< FAILURE!
org.opentest4j.AssertionFailedError: Response{protocol=http/1.1, code=404, message=, url=http://localhost:32770/eureka/v2/apps/ZIPKIN}

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt
Copy link
Member Author

maybe got the flake 🤞

@codefromthecrypt codefromthecrypt merged commit 899170c into master Jan 23, 2024
13 checks passed
@codefromthecrypt codefromthecrypt deleted the CASSANDRA_SSL_HOSTNAME_VALIDATION branch January 23, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants