Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segregation of registration from logging in #21

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

AndrewHUNGNguyen
Copy link
Collaborator

@AndrewHUNGNguyen AndrewHUNGNguyen commented Aug 28, 2024

Separated the login process from the registration process on Quill

Description

  1. Added two new text boxes and a static text telling where the Registration begins below the Login button.
  2. Changed ng-model attribute name for the newly created text boxes for Account Registration so that when users type in email or password for account login, then the text boxes for email or password for account registration do not get filled at the same time

Motivation and Context

Gives better UX experience by providing clarity on how to create an account vs how to sign into an existing acount

How Has This Been Tested

Manually tested for the following cases in the video underneath the Screenshots and Videos section:

  1. Logging in with an existing account
  2. Attempting to register with a non-existing account
  3. Attempting to register with an existing account
  4. Logging back into an account created in Step 2
  5. Performed manual regression testing on Forget Password

Tested locally as a docker image

Screenshots and Videos

Video #1: Attempting to sign in to an existing account using andnu941@gmail.com
https://github.com/user-attachments/assets/22ccee83-ecff-4a9f-a483-1001dcd9de31

Video #2: Use cases attempted are
(1) register with sexcrunnerbythebeach@gmail.com
(2) log back into account created in above case
(3) Attempting to create an account for sexcrunnerbythebeach@gmail.com after creating in (1)
(4) Manual regression testing on the clicking of Forgot Password?

Screen.Recording.2024-08-28.at.12.55.08.AM.mov

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@AndrewHUNGNguyen AndrewHUNGNguyen requested a review from gregv August 28, 2024 08:21
@gregv gregv merged commit c16a7cb into opportunity-hack:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants