Surface a schema
assertion on bodies for rule runner
#2672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍗 Description
What does this PR do? Anything folks should know?
Ended up changing this PR to emit
schema
facts on any schema. Previously, we had body facts (on root body nodes) and property facts (on keys of objects) but this missed out on polymorphic items and array items.Schema now triggers on all of the above cases and includes context related data depending on where the schema originated from (including required and key for fields). See example
Keeping the old field and body facts in for backwards compatibility, but I think schema can be used for all future rule cases since it asserts on the schema object.
📚 References
Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.
👹 QA
How can other humans verify that this PR is correct?