[GR-61443] [GR-61549] Fix which resolution errors are remembered in the constant pool. #10606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff makes the changes look a bit more complex than they are:
ResolvedClassConstant
is split intoResolvedFoundClassConstant
&ResolvedFailClassConstant
.CallSiteLink
is split intoSuccessfulCallSiteLink
&FailedCallSiteLink
.FailInvokeDynamicConstant
is gone and as a resultLinkableInvokeDynamicConstant
is not necessary and also removed.CallSiteLinkingFailure
is gone.AbstractStickyFailure
is created to share the behaviour of all failures that need to be remembered:AbstractFailedConstant
)ResolvedInvokeDynamicConstant
(as aFailedCallSiteLink
)ClassConstant.WithString
&PreResolvedClassConstant
were already unused and are removed.