refactor(test):removed access to storage in tests where is not needed

tests/src/test/java/com/orientechnologies/orient/test/database/auto/BaseTest.java

@@ -2,7 +2,6 @@
 
 import com.orientechnologies.orient.core.db.ODatabase;
 import com.orientechnologies.orient.core.db.ODatabaseDocumentInternal;
-import com.orientechnologies.orient.core.db.ODatabaseInternal;
 import com.orientechnologies.orient.core.db.ODatabaseWrapperAbstract;
 import com.orientechnologies.orient.core.db.OrientDB;
 import com.orientechnologies.orient.core.db.OrientDBConfig;
@@ -269,7 +268,13 @@ protected boolean skipTestIfRemote() {
   }
 
   protected void checkEmbeddedDB() {
-    if (((ODatabaseInternal) database).getStorage().isRemote()) {
+    final ODatabaseDocumentInternal db;
+    if (database instanceof ODatabaseWrapperAbstract) {
+      db = (ODatabaseDocumentInternal) ((ODatabaseWrapperAbstract) database).getUnderlying();
+    } else {
+      db = (ODatabaseDocumentInternal) database;
+    }
+    if (db.isRemote()) {
       throw new SkipException("Test is running only in embedded database");
     }
   }

tests/src/test/java/com/orientechnologies/orient/test/database/auto/CollateTest.java

@@ -230,7 +230,7 @@ public void testCompositeIndexQueryCS() {
     Assert.assertTrue(
         explain.getExecutionPlan().get().getIndexes().contains("collateCompositeIndexCS"));
 
-    if (!database.getStorage().isRemote()) {
+    if (!database.isRemote()) {
       final OIndexManagerAbstract indexManager = database.getMetadata().getIndexManagerInternal();
       final OIndex index = indexManager.getIndex(database, "collateCompositeIndexCS");
 

tests/src/test/java/com/orientechnologies/orient/test/database/auto/DateTest.java

@@ -69,7 +69,7 @@ public void testDatePrecision() throws ParseException {
     final long begin = System.currentTimeMillis();
 
     String dateAsString =
-        database.getStorage().getConfiguration().getDateFormatInstance().format(begin);
+        database.getStorageInfo().getConfiguration().getDateFormatInstance().format(begin);
 
     ODocument doc = new ODocument("Order");
     doc.field("context", "testPrecision");

tests/src/test/java/com/orientechnologies/orient/test/database/auto/IndexTxAwareMultiValueGetEntriesTest.java

@@ -50,7 +50,7 @@ public void afterMethod() throws Exception {
 
   @Test
   public void testPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -92,7 +92,7 @@ public void testPut() {
 
   @Test
   public void testRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -135,7 +135,7 @@ public void testRemove() {
 
   @Test
   public void testRemoveOne() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -177,7 +177,7 @@ public void testRemoveOne() {
 
   @Test
   public void testMultiPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -212,7 +212,7 @@ public void testMultiPut() {
 
   @Test
   public void testPutAfterTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -241,7 +241,7 @@ public void testPutAfterTransaction() {
 
   @Test
   public void testRemoveOneWithinTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -275,7 +275,7 @@ public void testRemoveOneWithinTransaction() {
 
   @Test
   public void testRemoveAllWithinTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -308,7 +308,7 @@ public void testRemoveAllWithinTransaction() {
 
   @Test
   public void testPutAfterRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 

tests/src/test/java/com/orientechnologies/orient/test/database/auto/IndexTxAwareMultiValueGetTest.java

@@ -44,7 +44,7 @@ public void afterMethod() throws Exception {
 
   @Test
   public void testPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -89,7 +89,7 @@ public void testPut() {
 
   @Test
   public void testRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -138,7 +138,7 @@ public void testRemove() {
 
   @Test
   public void testRemoveOne() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -186,7 +186,7 @@ public void testRemoveOne() {
 
   @Test
   public void testMultiPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -217,7 +217,7 @@ public void testMultiPut() {
 
   @Test
   public void testPutAfterTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -243,7 +243,7 @@ public void testPutAfterTransaction() {
 
   @Test
   public void testRemoveOneWithinTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -269,7 +269,7 @@ public void testRemoveOneWithinTransaction() {
 
   @Test
   public void testPutAfterRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 

tests/src/test/java/com/orientechnologies/orient/test/database/auto/IndexTxAwareMultiValueGetValuesTest.java

@@ -49,7 +49,7 @@ public void afterMethod() throws Exception {
 
   @Test
   public void testPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -91,7 +91,7 @@ public void testPut() {
 
   @Test
   public void testRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -133,7 +133,7 @@ public void testRemove() {
 
   @Test
   public void testRemoveOne() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -173,7 +173,7 @@ public void testRemoveOne() {
 
   @Test
   public void testMultiPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -205,7 +205,7 @@ public void testMultiPut() {
 
   @Test
   public void testPutAfterTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -233,7 +233,7 @@ public void testPutAfterTransaction() {
 
   @Test
   public void testRemoveOneWithinTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -262,7 +262,7 @@ public void testRemoveOneWithinTransaction() {
 
   @Test
   public void testRemoveAllWithinTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -291,7 +291,7 @@ public void testRemoveAllWithinTransaction() {
 
   @Test
   public void testPutAfterRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 

tests/src/test/java/com/orientechnologies/orient/test/database/auto/IndexTxAwareOneValueGetEntriesTest.java

@@ -50,7 +50,7 @@ public void afterMethod() throws Exception {
 
   @Test
   public void testPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -91,7 +91,7 @@ public void testPut() {
 
   @Test
   public void testRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -131,7 +131,7 @@ public void testRemove() {
 
   @Test
   public void testRemoveAndPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -168,7 +168,7 @@ public void testRemoveAndPut() {
 
   @Test
   public void testMultiPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -200,7 +200,7 @@ public void testMultiPut() {
 
   @Test
   public void testPutAfterTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -229,7 +229,7 @@ public void testPutAfterTransaction() {
 
   @Test
   public void testRemoveOneWithinTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -258,7 +258,7 @@ public void testRemoveOneWithinTransaction() {
 
   @Test
   public void testPutAfterRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 

tests/src/test/java/com/orientechnologies/orient/test/database/auto/IndexTxAwareOneValueGetTest.java

@@ -46,7 +46,7 @@ public void afterMethod() throws Exception {
 
   @Test
   public void testPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -91,7 +91,7 @@ public void testPut() {
 
   @Test
   public void testRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -136,7 +136,7 @@ public void testRemove() {
 
   @Test
   public void testRemoveAndPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -177,7 +177,7 @@ public void testRemoveAndPut() {
 
   @Test
   public void testMultiPut() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -203,7 +203,7 @@ public void testMultiPut() {
 
   @Test
   public void testPutAfterTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -228,7 +228,7 @@ public void testPutAfterTransaction() {
 
   @Test
   public void testRemoveOneWithinTransaction() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }
 
@@ -253,7 +253,7 @@ public void testRemoveOneWithinTransaction() {
 
   @Test
   public void testPutAfterRemove() {
-    if (database.getStorage().isRemote()) {
+    if (database.isRemote()) {
       throw new SkipException("Test is enabled only for embedded database");
     }