Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/accessibility imrovements #232

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AleksejDix
Copy link

I went over the component and some of them could be fixed very fast.

I left explanations inside commits

Copy link

vercel bot commented Jan 29, 2025

@AleksejDix is attempting to deploy a commit to the Cruip Team on Vercel.

A member of the Team first needs to authorize it.

@pasqualevitiello
Copy link
Contributor

Hey @AleksejDix, thanks for your contribution! I really care about accessibility, even if I’m not an expert. Some changes make sense to me, others not so much. For example, removing h2 around anchors—I see this done a lot, and it’s useful for SEO too. How does it cause issues for screen readers?

Same for DialogContent: the output looks pretty much the same. Is there a reason why it should be removed?

I prefer making changes only when they really matter and, if needed, applying them consistently across all components. Would love to understand more so I can make the right call. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants